[experimental] Implement one-helper, "ping-pong" aggregation. #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This required a few other changes that may be notable: * I enabled the use of Poplar1 to test aggregation-continuation behavior. Neither Prio3 nor the dummy VDAF would work for this, as they do not have enough rounds to trigger continuation. (In retrospect, it may have been wiser to extend the dummy VDAF to allow the number of rounds to be controlled.) * I refactored the replay logic to store the last responses directly, and build current-round responses directly from the same data that would be used to handle replay. Replay state is now attached to the report aggregation, rather than the report aggregation state.
This came out of a code-editing error when refactoring this section of code.
It's necessary to reference an unreleased version of libprio-rs until divviup/libprio-rs@54a4623 is released. I need to change the reference since that PR has now been merged, and the underlying branch deleted.
|
I think it'd help reviewers to rebase this on #1253. |
Done. |
tgeoghegan
reviewed
Apr 20, 2023
There was a problem hiding this comment.
This looks like a sound implementation of ietf-wg-ppm/draft-ietf-ppm-dap#393 to me.
| @@ -867,26 +869,6 @@ mod tests { | |||
| ) | |||
| .await; | |||
|
|
|||
| // should reject a report with only one share with the unrecognizedMessage type. | |||
There was a problem hiding this comment.
Oh, cool, I hadn't thought about how this change removes the category of errors where vectors of objects are the wrong length!
There was a problem hiding this comment.
Yup -- that's one of the nice things about switching to leader/helper-specific fields. This is another advantage of specifying to exactly one helper.
11 tasks
|
Assigning to myself: I'll rebase this and sync it up with what got published in DAP-05. |
tgeoghegan
pushed a commit
that referenced
this pull request
Aug 16, 2023
tgeoghegan
pushed a commit
that referenced
this pull request
Aug 26, 2023
Merged
|
Ping pong was landed in #1811, closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experimental change following ietf-wg-ppm/draft-ietf-ppm-dap#393.
Other than specifying to one helper & implementing ping-ponging, there are a few related changes as well: